✅ Deploy Preview for dlt-hub-docs canceled.

thanks for the PR and extensive test suite! Your code looks good as well. Please submit your changes against devel branch. Unfortunately this version contains changes in gen_copy_sql (vectorized scanner option) so you'll get conflicts with your current version.

@rudolfix done 👍

thanks for the update. IMO vectorized scanner config options is not passed. also please mark your tests as essential (so we always run them - they are fast).

if you are ok with it: could you type signatures of your tests and fixtures? cursor probably can do that automatically.

we are typing all our tests and plan to make mypy more strict soon...

thanks!

Np on the tests... but I'm pretty sure use vectorized scanner is passed. There's a unit test that checks for it too.

please take a look at those tests:

FAILED tests/load/pipeline/test_snowflake_pipeline.py::test_snowflake_use_vectorized_scanner[TRUE-snowflake-parquet-staging-credential-forwarding] - AttributeError: type object 'SnowflakeLoadJob' has no attribute 'gen_copy_sql'
FAILED tests/load/pipeline/test_snowflake_pipeline.py::test_snowflake_use_vectorized_scanner[FALSE-snowflake-parquet-staging-credential-forwarding] - AttributeError: type object 'SnowflakeLoadJob' has no attribute 'gen_copy_sql'

here's the deleted arg: https://github.com/dlt-hub/dlt/pull/2354/files#diff-f4f94b7bc9fa2649ffaa9cb51df285bca77b5ea826d5dc026ddfe6f61207c946L113
what we recently did: we enabled tests that require ci access to run form forks. after your last merge from devel they finally run.

thanks for working on this :)

please take a look at those tests:

FAILED tests/load/pipeline/test_snowflake_pipeline.py::test_snowflake_use_vectorized_scanner[TRUE-snowflake-parquet-staging-credential-forwarding] - AttributeError: type object 'SnowflakeLoadJob' has no attribute 'gen_copy_sql'
FAILED tests/load/pipeline/test_snowflake_pipeline.py::test_snowflake_use_vectorized_scanner[FALSE-snowflake-parquet-staging-credential-forwarding] - AttributeError: type object 'SnowflakeLoadJob' has no attribute 'gen_copy_sql'

here's the deleted arg: https://github.com/dlt-hub/dlt/pull/2354/files#diff-f4f94b7bc9fa2649ffaa9cb51df285bca77b5ea826d5dc026ddfe6f61207c946L113 what we recently did: we enabled tests that require ci access to run form forks. after your last merge from devel they finally run.

thanks for working on this :)

Np! Sorry about that, it should work now. It's a pain that we can't emulate some of the destinations for local testing. I'm sure we could but it would be a real pain to set up...